-
-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate accordingly with content-type defined in spec #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🙈 decreasing code coverage.. |
rafaelcaricio
force-pushed
the
verify-content-type
branch
from
April 4, 2016 15:50
f360295
to
a2fc4a8
Compare
Going up again ☝️ |
@@ -48,7 +49,9 @@ def validate_response(self, data, status_code, headers): | |||
response_definition = self.operation.resolve_reference(response_definition) | |||
# TODO handle default response definitions | |||
|
|||
if response_definition and response_definition.get("schema"): | |||
if response_definition and "schema" in response_definition \ | |||
and (produces_json([self.mimetype]) or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using parenthesis here would look better than using line continuations ('').
👍 |
1 similar comment
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #203
Connexion should validate the schema of responses that have content-type as JSON.
Changes proposed in this pull request: